fix(wizard): align save button correctly when hideNavigation is true#1507
fix(wizard): align save button correctly when hideNavigation is true#1507
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request fixes an alignment issue with the 'save' button in the wizard component when navigation buttons are hidden. My review includes a suggestion to extend this fix to also cover the edge case where there is only a single step in the wizard, which presents a similar alignment problem, ensuring the button is correctly positioned in both scenarios.
There was a problem hiding this comment.
Pull request overview
Fixes a wizard footer layout edge case where, with hideNavigation enabled (previous/next hidden) and using the footer navigation layout, the Save button isn’t aligned to the end as expected.
Changes:
- Add conditional
endclass to the footer Save button whenhideNavigation()is true.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ljanner
force-pushed
the
fix/wizard-save-button-alignment
branch
from
530ffb1 to
5e8460d
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ljanner
force-pushed
the
fix/wizard-save-button-alignment
branch
from
5e8460d to
892f63e
Compare
|
Documentation. Coverage Reports: |
This fixes an edge case where hideNavigation is true and the previous/next buttons are hidden. Back port of #1507.
|
Team is asking for a back port, I already went ahead with creating it #1515 |
akashsonune
force-pushed
the
fix/wizard-save-button-alignment
branch
from
892f63e to
8f8b09f
Compare
|
|
This fixes an edge case where hideNavigation is true and the previous/next buttons are hidden.
ljanner
force-pushed
the
fix/wizard-save-button-alignment
branch
from
8f8b09f to
a5c38c6
Compare
4 participants
This fixes an edge case where hideNavigation is true and the previous/next buttons are hidden.
This can be tested with the wizard playground: